Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract offer ID is missing on catalog browser view page #795

Closed
tmberthold opened this issue Aug 14, 2024 · 2 comments · Fixed by #817 or #838
Closed

Contract offer ID is missing on catalog browser view page #795

tmberthold opened this issue Aug 14, 2024 · 2 comments · Fixed by #817 or #838
Assignees
Labels
bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. component/edc-ui affected software component kind/bug Something isn't working. The software does not behave as expected or specified. kind/enhancement New feature or request scope/mds related to MDS
Milestone

Comments

@tmberthold
Copy link
Member

tmberthold commented Aug 14, 2024

Bug

Description

After creating data offer search that data offer in catalog browser using connector endpoint url, When we click on the data offer user should be able to see contract offer id on catalog view page. The idea is that the participant can use the offer id for the API-triggered negotiation.

To reproduce:

Steps to reproduce the behavior:
- Go to 'Create Data Offer Page'
- Create Data Offer with datasource type "I want to connect to a datasource"
- Create policy and contract definition
- Search data offer catalog browser using connector endpoint url
- Click on data offer

Observed Behaviour

Added by AM on 02.09

  • Issue seems to happen after upgrade to edc-ee v4.0.0 / edc-ui v10.0.0

  • Bug successfully reproduced

    • on connector https://mds2-2-funtest-jakob.stage-sovity.azure.sovity.io/api/dsp
      image
    • on connector https://sovity-demo-b.stage-sovity.azure.sovity.io/api/dsp
  • As comparison, issue does not happen on sovity CaaS on edc-ee v3.6.0 / edc-ui v9.0.0 as tried out with connector https://sovity-demo-a.stage-sovity.azure.sovity.io/api/dsp
    image

Expected behavior

Contract offer id should be present on on catalog browser view page

Tasks

No tasks being tracked yet.
@tmberthold tmberthold added scope/mds related to MDS kind/enhancement New feature or request labels Aug 14, 2024
@tmberthold tmberthold added this to the MDS 2.2 milestone Aug 14, 2024
@AbdullahMuk AbdullahMuk added kind/bug Something isn't working. The software does not behave as expected or specified. bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. labels Aug 22, 2024
@AbdullahMuk
Copy link
Collaborator

@illfixit please review my findings in the section Observed Behaviour. Please confirm if this bug is frontend related only; based on your feedback we will align further on how to fix it.

@tmberthold
Copy link
Member Author

Unfortunately, the content of the ID field is cut off in the UI, which means that not the complete ID is displayed.

UI:
image

In reality should be:
dGVzdHRlc3R0ZXN0dGVzdHRlc3Q=:dGVzdHRlc3R0ZXN0dGVzdHRlc3Q=:MDE5MjA4ZWMtMjI0My03YmEyLWE5ZGYtYzRjZTZkZDEyYzAx

@illfixit illfixit linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. component/edc-ui affected software component kind/bug Something isn't working. The software does not behave as expected or specified. kind/enhancement New feature or request scope/mds related to MDS
Projects
None yet
3 participants