perf(projects): perf code

soybeanjs · Nov 16, 2023 · 324cffd · 324cffd
1 parent c2b6aa6
commit 324cffd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/packages/hooks/src/use-svg-icon-render.ts b/packages/hooks/src/use-svg-icon-render.ts
@@ -4,9 +4,8 @@ import type { Component } from 'vue';
 /**
  * svg icon render hook
  * @param SvgIcon svg icon component
- * @param defaultIcon default icon name (iconify icon name)
  */
-export default function useSvgIconRender(SvgIcon: Component, defaultIcon: string) {
+export default function useSvgIconRender(SvgIcon: Component) {
   interface IconConfig {
     /**
      * iconify icon name
@@ -33,7 +32,7 @@ export default function useSvgIconRender(SvgIcon: Component, defaultIcon: string
    * @param config
    */
   const SvgIconVNode = (config: IconConfig) => {
-    const { color, fontSize, icon = defaultIcon, localIcon } = config;
+    const { color, fontSize, icon, localIcon } = config;
 
     const style: IconStyle = {};
 

diff --git a/src/components/common/lang-switch.vue b/src/components/common/lang-switch.vue
@@ -1,6 +1,5 @@
 <script setup lang="ts">
 import { computed } from 'vue';
-import type { TooltipPlacement } from 'ant-design-vue/es/tooltip';
 import { $t } from '@/locales';
 
 defineOptions({
@@ -20,15 +19,10 @@ interface Props {
    * show tooltip
    */
   showTooltip?: boolean;
-  /**
-   * tooltip placement
-   */
-  tooltipPlacement?: TooltipPlacement;
 }
 
 const props = withDefaults(defineProps<Props>(), {
-  showTooltip: true,
-  tooltipPlacement: 'left'
+  showTooltip: true
 });
 
 type Emits = {

diff --git a/src/store/modules/route/shared.ts b/src/store/modules/route/shared.ts
@@ -97,7 +97,7 @@ export function updateLocaleOfGlobalMenus(menus: App.Global.Menu[]) {
  * @param route
  */
 function getGlobalMenuByBaseRoute(route: RouteLocationNormalizedLoaded | ElegantConstRoute) {
-  const { SvgIconVNode } = useSvgIconRender(SvgIcon, import.meta.env.VITE_MENU_ICON);
+  const { SvgIconVNode } = useSvgIconRender(SvgIcon);
 
   const { name, path } = route;
   const { title, i18nKey, icon, localIcon } = route.meta ?? {};