Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of invalid chars (ÆØÅ) #1667

Open
f-o opened this issue Jan 17, 2025 · 0 comments
Open

Removal of invalid chars (ÆØÅ) #1667

f-o opened this issue Jan 17, 2025 · 0 comments

Comments

@f-o
Copy link

f-o commented Jan 17, 2025

Hello,

The script seems to be completely removing any "illegal" chars in the folder/filenames, as per the text.py utility-file.
Namely I'm referring to the Danish/Norwegian Æ, Ø, and Å.
This leads to filenames being incorrect, and breaks media players possibilities to correctly search for metadata.

Per naming conventions, the proper replacement mapping would be:

  • æ - ae
  • ø - oe
  • å - aa

I believe this is a simple oversight in the script, as these are possible edge cases. But it does affect the script in a way that breaks DK/NO services.

We can parse the titles manually in the specific service files, but instead of having repeat code, I feel it would be best to address this issue in the main filenamify() function.
A simple fix could be:

title = title.replace("æ", "ae").replace("ø", "oe").replace("å", "aa")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant