Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - sync2: multipeer: fix edge cases #6447

Closed
wants to merge 14 commits into from

Merge branch 'develop' into sync2/fix-multipeer

989dc18
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - sync2: multipeer: fix edge cases #6447

Merge branch 'develop' into sync2/fix-multipeer
989dc18
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 4, 2024 in 1s

79.9% (+0.0%) compared to 06f74fa

View this Pull Request on Codecov

79.9% (+0.0%) compared to 06f74fa

Details

Codecov Report

Attention: Patch coverage is 72.22222% with 25 lines in your changes missing coverage. Please review.

Project coverage is 79.9%. Comparing base (06f74fa) to head (989dc18).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sync2/p2p.go 68.1% 13 Missing and 1 partial ⚠️
sync2/multipeer/multipeer.go 71.4% 4 Missing and 2 partials ⚠️
sync2/multipeer/split_sync.go 78.2% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #6447   +/-   ##
=======================================
  Coverage     79.8%   79.9%           
=======================================
  Files          353     353           
  Lines        46540   46602   +62     
=======================================
+ Hits         37161   37248   +87     
+ Misses        7268    7244   -24     
+ Partials      2111    2110    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov