Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend systest with option to add split node setup #6506

Closed
wants to merge 11 commits into from

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Nov 28, 2024

Motivation

Tune systests to run smeshers as pair of pods - node and activation.

Description

Note: split node setup will always deploy non smeshing node
to which there will be deployed connected n-1 activation nodes.
Because of that - node-split-size has to be set to 0 or >1.

Test Plan

Manual testing.

TODO

  • Check if that's still working with OldSize != 0
  • Validate with @kacpersaw if config/cmdline args for activation part is correct

@jellonek jellonek marked this pull request as draft November 28, 2024 12:36
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.3%. Comparing base (05ba7fb) to head (46b1975).
Report is 1 commits behind head on node-split-poc.

Additional details and impacted files
@@               Coverage Diff                @@
##           node-split-poc   #6506     +/-   ##
================================================
- Coverage            77.3%   77.3%   -0.1%     
================================================
  Files                 341     341             
  Lines               45737   45737             
================================================
- Hits                35378   35367     -11     
- Misses               8246    8254      +8     
- Partials             2113    2116      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jellonek jellonek changed the title Extend systest to split smeshers to node/activation pairs Extend systest with option to add split node setup Nov 29, 2024
Note: split node setup will always deploy non smeshing node
to which there will be deployed connected n-1 activation nodes.
Because of that - node-split-size has to be set to 0 or >1.
@jellonek
Copy link
Contributor Author

jellonek commented Dec 5, 2024

Closing in favor of #6520 #6521 and #6522 which contain the same changes splitted into 3 separate commits, which also are rebased on current top of the target branch.

@jellonek jellonek closed this Dec 5, 2024
@jellonek jellonek deleted the nodesplit/systest branch December 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants