Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-split poc: add proposal publish failed state #6514

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

kacpersaw
Copy link
Contributor

Description

This PR adds support for new state PROPOSAL_PUBLISH_FAILED

Error handling improvements:

  • identity/state.go: Added a new ProposalPublishFailed struct and its corresponding APIStateInfo method to handle proposal publish failures.
  • miner/remote_proposals.go: Updated the identityStates interface to include a new Set method and used it to handle proposal publish failures in the build method. [1] [2]

@kacpersaw kacpersaw merged commit 913a87a into node-split-poc Dec 4, 2024
14 checks passed
@kacpersaw kacpersaw deleted the node-split-poc-failed-proposal branch December 4, 2024 16:06
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 77.2%. Comparing base (e6dea00) to head (49bbb0b).
Report is 3 commits behind head on node-split-poc.

Files with missing lines Patch % Lines
identity/state.go 0.0% 11 Missing ⚠️
miner/remote_proposals.go 14.2% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           node-split-poc   #6514     +/-   ##
================================================
- Coverage            77.2%   77.2%   -0.1%     
================================================
  Files                 342     342             
  Lines               45822   45839     +17     
================================================
+ Hits                35385   35391      +6     
- Misses               8324    8330      +6     
- Partials             2113    2118      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jellonek pushed a commit that referenced this pull request Dec 5, 2024
node-split poc: add proposal publish failed state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants