From 5a0e861a2f69ec31896baec9a192f64c7dae3d89 Mon Sep 17 00:00:00 2001 From: "Brett M. Morris" Date: Fri, 27 Sep 2024 15:44:02 -0400 Subject: [PATCH] addressing review comments --- CHANGES.rst | 3 ++- jdaviz/configs/rampviz/helper.py | 4 ++-- jdaviz/configs/rampviz/plugins/viewers.py | 5 ++++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 744cfcc63b..be7ada2e28 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -21,7 +21,8 @@ New Features - The standalone version of jdaviz now uses solara instead of voila, resulting in faster load times. [#2909] -- New configuration for ramp/Level 1 data products from Roman WFI and JWST [#3120, #3148, #3167, #3171, #3194] +- New configuration for ramp/Level 1 and rate image/Level 2 data products from Roman WFI and + JWST [#3120, #3148, #3167, #3171, #3194] - Unit columns are now visible by default in the results table in model fitting. [#3196] diff --git a/jdaviz/configs/rampviz/helper.py b/jdaviz/configs/rampviz/helper.py index 0eb521f5be..b43a7c0888 100644 --- a/jdaviz/configs/rampviz/helper.py +++ b/jdaviz/configs/rampviz/helper.py @@ -114,11 +114,11 @@ def create_image_viewer(self, viewer_name=None, data=None): Image viewer instance. """ - from jdaviz.configs.imviz.plugins.viewers import ImvizImageView + from jdaviz.configs.rampviz.plugins.viewers import RampvizImageView # Cannot assign data to real Data because it loads but it will # not update checkbox in Data menu. return self.app._on_new_viewer( - NewViewerMessage(ImvizImageView, data=None, sender=self.app), + NewViewerMessage(RampvizImageView, data=None, sender=self.app), vid=viewer_name, name=viewer_name) diff --git a/jdaviz/configs/rampviz/plugins/viewers.py b/jdaviz/configs/rampviz/plugins/viewers.py index e394c41912..19a790722a 100644 --- a/jdaviz/configs/rampviz/plugins/viewers.py +++ b/jdaviz/configs/rampviz/plugins/viewers.py @@ -131,7 +131,10 @@ def _initial_x_axis(self, *args): ref_data = self.state.reference_data if ref_data: - self.state.x_att = ref_data.id["Pixel Axis 0 [z]"] + if "Pixel Axis 0 [z]" in [comp.label for comp in ref_data.components]: + self.state.x_att = ref_data.id["Pixel Axis 0 [z]"] + else: + self.state.x_att = ref_data.id["Pixel Axis 0 [y]"] def set_plot_axes(self): self.figure.axes[1].tick_format = None