Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdaviz-cube writer should also write out uncertainty #2044

Closed
Jdaviz-Triage-Bot opened this issue Feb 28, 2023 · 0 comments · Fixed by #2094
Closed

jdaviz-cube writer should also write out uncertainty #2044

Jdaviz-Triage-Bot opened this issue Feb 28, 2023 · 0 comments · Fixed by #2094
Labels
cubeviz feature Feature request

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Feb 28, 2023

Reporter: pllim

In #2012 , custom writer we added to write out fitted 3D cube only serializing SCI and MASK extensions in FITS file. If the cube has uncertainty, that also should be serialized out to the file. Usually, the order goes like this:

  1. Primary header
  2. SCI
  3. UNCERT
  4. MASK

Some telescope use ERR, IVAR, VAR (and so on) instead of UNCERT. I do not know of any official global convention for this.

Care also needs to be given to automatically translate different uncertainty types in this writer into a valid FITS HDU that can be read in exactly the same (roundtripping).

Currently, a lot of operations do not propagate uncertainty, so probably not high priority to implement? Nice to have in case someone has a cube with the uncertainty and wants to use this writer (outside of Cubeviz plugin).

Also see:

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants