Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup.cfg that was accidentally reintroduced #2331

Closed
Jdaviz-Triage-Bot opened this issue Aug 1, 2023 · 0 comments · Fixed by #2333
Closed

Remove setup.cfg that was accidentally reintroduced #2331

Jdaviz-Triage-Bot opened this issue Aug 1, 2023 · 0 comments · Fixed by #2333
Labels
bug Something isn't working

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Aug 1, 2023 •
edited by pllim
Loading

Reporter: pllim

After #1661 , there should be no more setup.cfg file but now I see that it is back. My suspicion is that one of the old PRs rebased incorrectly and then got merged, accidentally re-introducing it. We should remove setup.cfg again ASAP because this is a maintenance disaster waiting to happen.

Thanks to @dhomeier for catching this over at glue-viz/glue-jupyter#376

🐱

DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MNT: Fix setup set up pllim/jdaviz
2 participants
@pllim @Jdaviz-Triage-Bot