From 5c914a085b8f8f16e4133ffb8f268b8b67484f11 Mon Sep 17 00:00:00 2001 From: Kyle Conroy Date: Tue, 29 Aug 2023 16:04:24 -0400 Subject: [PATCH] fix case of a multiselect dropdown becoming single when no selection --- CHANGES.rst | 4 ++++ jdaviz/core/template_mixin.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGES.rst b/CHANGES.rst index d7e8652dc0..a9564160cc 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -97,6 +97,10 @@ Other Changes and Additions Bug Fixes --------- +- Fixes turning off multiselect mode for a dropdown when no selections are currently made. + Previously this resulted in a traceback, but now applies the default selection for + single-select mode. [#2404] + Cubeviz ^^^^^^^ diff --git a/jdaviz/core/template_mixin.py b/jdaviz/core/template_mixin.py index 47a462d613..e0d4ec564f 100644 --- a/jdaviz/core/template_mixin.py +++ b/jdaviz/core/template_mixin.py @@ -736,7 +736,7 @@ def _multiselect_changed(self, event): self._clear_cache() if self.is_multiselect: self.selected = [self.selected] - elif isinstance(self.selected, list): + elif isinstance(self.selected, list) and len(self.selected): self.selected = self.selected[0] else: self._apply_default_selection()