RCAL-895: allow updating source catalog with tweaked WCS when running ELP

[mairanteodoro]

Resolves RCAL-895

This PR implements the update of the source catalog coordinates using the improved WCS calculated by TweakRegStep when processing data through the ELP.

When running the ELP, at the end of the TweakRegStep, the cat file produced by SourceCatalogStep (containing all the sources coordinates) will be read in, updated with the new WCS function, and saved back to disk (overwriting the file content).

Regression tests
All tests are passing: https://github.com/spacetelescope/RegressionTests/actions/runs/11034994349

Checklist

• added entry in CHANGES.rst under the corresponding subsection
• updated relevant tests
• updated relevant documentation
• updated relevant milestone(s)
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (3107d3d) to head (e19cf1a).

Files with missing lines	Patch %	Lines
romancal/pipeline/exposure_pipeline.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
+ Coverage   78.67%   78.71%   +0.04%     
==========================================
  Files         117      117              
  Lines        7728     7738      +10     
==========================================
+ Hits         6080     6091      +11     
+ Misses       1648     1647       -1     

Flag	Coverage Δ		*Carryforward flag
nightly	62.26% <ø> (ø)		Carriedforward from a6c03ec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[schlafly]

Thanks Mairan, looks, good, one comment inline.

[schlafly]

Thanks, this looks good to me. And it looks like regtests were passing last week; I presume that's still the case?

Maybe just mentioning this aloud for the moment, I originally expected regtests to fail, since we should be changing the values of the catalog entries. But we don't do compare_asdf against the catalog files (reasoning that it's extra hard to guarantee they don't change), and so we don't expect this change to lead to regtest differences.

[mairanteodoro]

Thanks, this looks good to me. And it looks like regtests were passing last week; I presume that's still the case?

Yes, after fixing the "second okify issue" that you mentioned today in the standup meeting, the regtests for this PR are still passing: https://github.com/spacetelescope/RegressionTests/actions/runs/11034994349