-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-900: fix numpy 2.0 issues with bitflags in resample #1383
Conversation
4403277
to
099ade2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
- Coverage 78.49% 78.46% -0.03%
==========================================
Files 117 117
Lines 7867 7866 -1
==========================================
- Hits 6175 6172 -3
- Misses 1692 1694 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5a491b6
to
66b3c18
Compare
I ran a regtest through the new GitHub Actions system here: |
f58ddf0
to
09dc55f
Compare
b292584
to
1f2e019
Compare
Is this ready to merge? |
Yes |
…ope#1383) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: zacharyburnett <zburnett@stsci.edu>
Resolves RCAL-900
Closes #1279
This PR addresses an incompatibility in the
build_mask
function used by the resample step withnumpy 2.0
. This PR deprecates this function and instead switches to the equivalent function fromastropy.nddata.bitmask
.Checklist
CHANGES.rst
under the corresponding subsectionRegression tests running here: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/835/