Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-900: fix numpy 2.0 issues with bitflags in resample #1383

Merged
merged 5 commits into from
Sep 8, 2024

Conversation

mcara
Copy link
Member

@mcara mcara commented Aug 26, 2024

Resolves RCAL-900

Closes #1279

This PR addresses an incompatibility in the build_mask function used by the resample step with numpy 2.0. This PR deprecates this function and instead switches to the equivalent function from astropy.nddata.bitmask.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

Regression tests running here: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/835/

@mcara mcara requested a review from a team as a code owner August 26, 2024 20:33
@mcara mcara force-pushed the RCAL-864-bitflag branch 2 times, most recently from 4403277 to 099ade2 Compare August 26, 2024 20:52
@mcara mcara self-assigned this Aug 26, 2024
@mcara mcara added bug Something isn't working resample labels Aug 26, 2024
@mcara mcara added this to the 24Q4_B15 milestone Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (9e2b4d3) to head (cd5e39a).
Report is 258 commits behind head on main.

Files with missing lines Patch % Lines
romancal/resample/resample_utils.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1383      +/-   ##
==========================================
- Coverage   78.49%   78.46%   -0.03%     
==========================================
  Files         117      117              
  Lines        7867     7866       -1     
==========================================
- Hits         6175     6172       -3     
- Misses       1692     1694       +2     
Flag Coverage Δ *Carryforward flag
nightly 62.24% <ø> (ø) Carriedforward from 1f2e019

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator

I ran a regtest through the new GitHub Actions system here:
https://github.com/spacetelescope/RegressionTests/actions/runs/10578026904
It nominally fails but the failures are the same as on main and are unrelated to this PR, so the regtest looks good to me. Code looks good to me, thanks.

CHANGES.rst Outdated Show resolved Hide resolved
@nden
Copy link
Collaborator

nden commented Sep 8, 2024

Is this ready to merge?

@mcara
Copy link
Member Author

mcara commented Sep 8, 2024

Yes

@zacharyburnett zacharyburnett merged commit 908f0f9 into spacetelescope:main Sep 8, 2024
29 of 30 checks passed
@nden nden changed the title RCAL-864: fix numpy 2.0 issues with bitflags in resample RCAL-900: fix numpy 2.0 issues with bitflags in resample Sep 9, 2024
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Sep 10, 2024
…ope#1383)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: zacharyburnett <zburnett@stsci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resample
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitflags in resample fail with devdeps
4 participants