Work around NotImplemented Quantity.tofile

[braingram]

This is a follow-up to #1357 to fix a but revealed during other testing.

Calling OutlierDetection with on_disk=True fails with:

 NotImplementedError: cannot write Quantities to file.  Write array with q.value.tofile(...)

This PR works around the issue that calling tofile (which stcal now uses) is unsupported for Quantities.

This bug was hidden as the unit test that sets in_memory=True for outlier detection didn't provide an on_disk ModelLibrary which bypassed the call to tofile in stcal. This PR also updates the unit test to now check for that condition.

Regression tests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/11167537599

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (8601da8) to head (f2c004d).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1436   +/-   ##
=======================================
  Coverage   78.38%   78.38%           
=======================================
  Files         118      118           
  Lines        7680     7680           
=======================================
  Hits         6020     6020           
  Misses       1660     1660           

Flag	Coverage Δ		*Carryforward flag
nightly	62.12% <ø> (ø)		Carriedforward from 8601da8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mairanteodoro]

Looks good to me! Thanks, @braingram!