Restore flux units to source catalog table

[larrybradley]

This PR restores flux units to the source catalog table. The units were no longer included after a recent schema change.

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (efe4f32) to head (109d7eb).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   76.25%   76.26%   +0.01%     
==========================================
  Files         115      115              
  Lines        7639     7644       +5     
==========================================
+ Hits         5825     5830       +5     
  Misses       1814     1814              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[larrybradley]

The failing tests are unrelated to this PR:
AttributeError: No such attribute (sw_version) found in node

[schlafly]

I think this issue was just related to not being based on the most recent main; merging in main seems to have resolved it. I am leery of adding units to the model and removing them again---I would have guessed that the data model complains when the ndarrays are replaced with quantities. But we can revisit that in a later PR.

[larrybradley]

I would have guessed that the data model complains when the ndarrays are replaced with quantities. But we can revisit that in a later PR.

Using the dict syntax avoids the validator. In #1457, the data and err array will be copies and the "removing again" step will be unnecessary. But I need this PR to be merged first.

[schlafly]

Thanks, that makes sense. I'm running regtests here:
https://github.com/spacetelescope/RegressionTests/actions/runs/11825383574
and will merge after those pass.

[schlafly]

All green, thanks. https://github.com/spacetelescope/RegressionTests/actions/runs/11825383574