Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class was only introduced because older OS versions we no longer support didn't have NSURLRequest support NSSecureCoding. Apple's documentation implies this was supported from macOS 10.9 onwards.
Fixes #2124
Misc Checklist:
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Tested that network service type, http headers, timeout interval, URL, cache policy are all preserved through a test app which encoded/decoded NSURLRequest object via NSSecureCoding on macOS 10.10.5 (VM) and macOS 12.4.
Tested that Test App still works normally. Tested another sample app using downloader XPC Service still works.
Interesting to note: one of the NSURLRequest properties isn't encoded/decoded properly on macOS 10.9, but that doesn't matter now.
macOS version tested:
12.4 (21F79)
10.10.5 (14F27) VM