Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra writeData: call when unarchiving disk images #2562

Merged
merged 1 commit into from
May 20, 2024

Conversation

zorgiepoo
Copy link
Member

Remove extraneous writeData: call when unarchiving disk image files.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Ran unit tests for unarchiving dmg files.

macOS version tested: 14.5 (23F79)

@zorgiepoo zorgiepoo added this to the 2.6.3 milestone May 20, 2024
@zorgiepoo zorgiepoo merged commit f904466 into 2.x May 20, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the remove-extra-write-dmg branch May 20, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant