Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if node doesnt have parent unlink in jruby should return self. #1152

Closed
wants to merge 1 commit into from
Closed

if node doesnt have parent unlink in jruby should return self. #1152

wants to merge 1 commit into from

Conversation

esse
Copy link
Contributor

@esse esse commented Aug 30, 2014

If node doesn't have parent node - simply return self, as would Nokogiri for C would do, because that means that node is already detached (test case included).

This commit fixes issue #1112.

@flavorjones
Copy link
Member

Thanks for submitting this! I've cleaned up the implementation with a subsequent commit, and added more explicit test coverage in test/xml/test_unparented_node.rb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants