Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screening room: needs a number of fixups #1568

Open
5 tasks
yarikoptic opened this issue Jun 17, 2021 · 3 comments
Open
5 tasks

Screening room: needs a number of fixups #1568

yarikoptic opened this issue Jun 17, 2021 · 3 comments

Comments

@yarikoptic
Copy link
Contributor

yarikoptic commented Jun 17, 2021

  • search is plain straight fuss.js without what was done for posters hall. impossible to find anything (e.g. by author name) Improve search in Screening Room #1448
  • title for the https://ohbm.sparkle.space/in/screeningroom web page says "OHBM2021- Poster Hall" not "OHBM2021- Screening Room"
  • would be a nice UX to "scroll to top" to the video pane if I hit on a preview down in the list of videos, and ideally go back to the original location when I close that video . Otherwise it is at least confusing and requires figuring out to scroll to the top to actually see the video when "Now playing" appears overlayed on top of the preview (note: click on "Now playing" also doesn't scroll up)
  • "now playing" is factually incorrect since clicking/selecting a video doesn't actually start playing it. I think it would be a nice UX addition to start playing video as soon as it is selected
  • minor: all titles prepended with "1.". Not sure what that is about

Otherwise -- I really like it! well done!

attn @margulies

@katjaq
Copy link

katjaq commented Jun 17, 2021

Yes, indeed, super nice! I would like to add to the list above that in screening room space for poster highlights and symposia, the cards for each symposium are very thin, and yet they expand way beyond the screen width. The right most card is well readable, the left most card is cut.

Maybe we could arrange the poster highlight and symposia cards in 2 rows instead of one?

Otherwise, it works very nicely ✨

@katjaq
Copy link

katjaq commented Jun 17, 2021

just saw your PR #1564 aims at fixing this ! Looks great! 🚀

@katjaq
Copy link

katjaq commented Jun 21, 2021

workaround with a bookmarklet? :D
This is a bookmarklet to play the video in the screening room right where you are instead of scrolling up etc...

javascript:(function(){dqs=document.querySelector(".ScreeningRoom__video-cover").style;dqs.position="fixed";dqs.zIndex="100";dqs.backgroundColor="rgba(0,0,0,0.5)"})(); 

😄
(well, it's not perfect... you have to click every time :upside_down: but you don't lose your position ^^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants