-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementing a leaderboard #63
Comments
Happy to factor out code from https://github.com/kjappelbaum/mofdscribe/blob/main/dev_scripts/update_bench.py if it helps. The idea I use in mofdscribe is that there is one json that is produced. These docs are compiled to RST which can then be used by a sphinx extension to create the tables. (And you can also embed some interactive plot as HTML). |
@kjappelbaum ooh, interesting! I'd like to dig into this some more. |
Hi @kjappelbaum, I'm recircling this and planning to submit another JOSS manuscript. I think implementing a simple leaderboard within the repository would be best rather than trying to incorporate it elsewhere. Would you still be willing to factor out the leaderboard code from mofdscribe like you mentioned? |
Ah, somehow I didn't get the notification from this issue. From our email thread
If we both agree on this setup, I'll make some time end of next week to do it. |
@kjappelbaum no worries, I think I sent this message concurrently with the email thread. This sounds great to me. Thank you! |
Would probably be good to have a somewhat temporary leaderboard (either in the README or as a separate markdown file that gets displayed prominently on the documentation page) and then in the long-term add it to Matbench. materialsproject/matbench#150 (comment)
For the short-term implementation, maybe just tables with bolding applied to the best values within some tolerance (5% perhaps). Might be nice to be able to see composition vs. structural vs. composition + structure metrics, with the default or most prominently displayed metrics being composition + structure. In other words, display the combined metric where both structure and composition conditions need to be met. The other two (only req is meeting composition condition and only req is meeting structure condition) are instructive and help us understand where certain algorithms are lacking. Right now, I don't think the API tracks the composition and structure conditions independently from each other.
The text was updated successfully, but these errors were encountered: