Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type #452

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix return type #452

merged 1 commit into from
Nov 22, 2023

Conversation

riesjart
Copy link
Contributor

Spatie\Crawler\Crawler::startCrawling() accepts any instance of Psr\Http\Message\UriInterface.
When e.g. an instance of Spatie\Url\Url has been provided, everything goes well until Spatie\Crawler\Handlers\CrawlRequestFulfilled::getBaseUrl() fails to return an instance of GuzzleHttp\Psr7\Uri instead of the PSR interface. The code doesn't depend on the concrete Guzzle Uri however.

@freekmurze freekmurze merged commit 6983c78 into spatie:main Nov 22, 2023
4 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants