tapactivity description does not save properly

[rxng]

Hi,

Not sure if this is a bug, but I am trying to get tapActivity() to save meaningful descriptions besides just "Update".

For example, when a user logs in, I need it to save a log with description "Logged in"

public function tapActivity(Activity $activity, string $eventName)
{
    if($activity->properties["attributes"]["last_login"]) {
        $activity->description = "Logged in";
    }
}

However, this code doesn't work and description keeps defaulting back to "Update". It's really frustrating and wonder if anyone has a solution?

[Gummibeer]

Hey,
do you have started to debug it? So dump if it goes into the if, what is the value of $activity->description after the if and so on?

[Gummibeer]

Ok, I've checked the code and found the problem:

laravel-activitylog/src/Traits/LogsActivity.php

Lines 41 to 50 in 9b0e2da

	$logger = app(ActivityLogger::class)
	->useLog($logName)
	->performedOn($model)
	->withProperties($attrs);
	if (method_exists($model, 'tapActivity')) {
	$logger->tap([$model, 'tapActivity'], $eventName);
	}
	$logger->log($description);

laravel-activitylog/src/ActivityLogger.php

Line 135 in 9b0e2da

$activity->description = $this->replacePlaceholders($description, $activity);

The description is the only attribute set after the tapActivity() call. I will try to find a way to fix it.

[rxng]

Confirming that

dd($activity->description) at the end of the function yields correct new description, just not saving to database correctly.

[Gummibeer]

@rxng could you please test and verify dev-fix-issue-562? The unittest passes but a realworld test would be great.

[rxng]

@Gummibeer sure thing, how do I get this? I ran

composer require spatie/laravel-activitylog

but got

Using version ^3.2 for spatie/laravel-activitylog
Nothing to install or update

[Gummibeer]

You have to run it with the version, or just edit the version in composer.json

composer require spatie/laravel-activitylog:dev-fix-issue-562

[rxng]

@Gummibeer

"Package spatie/laravel-activitylog at version dev-fix-issue-562 has a PHP requirement incompatible with your PHP version (7.1.25) "

[Gummibeer]

That's right - the latest versions require PHP7.2.

[Gummibeer]

https://github.com/spatie/laravel-activitylog/releases/tag/3.6.2

[rxng]

I'm having trouble installing this into my Laravel 5.5 after upgrading to php 7.2

Noticed, you released into 3.6.2, so I tried to get that version but am getting this

spatie/laravel-activitylog 3.6.2 requires illuminate/database ~5.8.0

Any chance I can try and get the fix in? Sorry for the inconvenience but I am stuck!

Thanks :)

[Gummibeer]

As first solution I can only recommend you to upgrade to the latest laravel version. => LTS is a lie

As second solution you could override the ActivityLogger service and paste the fix from the PR in your overridden service.

Because it's not a security fix I won't add it to an older version.

[rxng]

Thank you, Tom. I will try to work around that until I can safely upgrade all my systems.

Sorry to be a pain, could you advise on how we might achieve this override?

Hopefully someone else can benefit from this too!

[Gummibeer]

Hey,

You just have to create a new class which extends the package ActivityLogger and copy the method updated in the PR in the new class.
After this you just have to bind your new class to the old one in a service provider.

$this->app->bind(
    ActivityLogger::class,
    YourNewActivityLogger::class
);