Fix setting the name via download() #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a test like this that was failing after updating to 1.5:
The reason being that
$pdf->downloadName
is still an empty string, despite calling->download($invoice->filename)
in the controller.I believe this fixes #138.
Oddly enough some tests including
the pdf function download accepts a name parameter and sets downloadName
failed on the old implementation, so not sure how that one got through 🤷♂️