Exception Not Thrown on Webhook Retry Failure

[JimmyBastos]

Hello,

I'm encountering an issue with a project that utilizes laravel-webhook-server@^3.6 within the Laravel Bref (Lambda) environment alongside SQS Queues. Specifically, I'm attempting to delegate webhook retries to the SQS queue. However, I've encountered a problem where an exception is not thrown when the final webhook retry fails, and the job is released from the queue.

I've configured the webhook server with the following settings in the 'config/webhook-server.php' file:

'throw_exception_on_failure' => true,
'tries' => 1,

Despite configuring it this way, when the webhook call job fails, the exception is not thrown, and the job execution is marked as successful.

Upon further investigation, I debugged the code in my local environment with a sync queue connection and noticed that the ->fail() method is indeed being called in the CallWebhookJob here. However, after taking a look at the Laravel CallQueuedHandler implementation here, I realized that the exception is only thrown if the job itself explicitly throws an exception in its failed method.

This behavior seems inconsistent with the configured settings, and I believe it may be a problem in the CallWebhookJob.

To reproduce the problem, I've provided a code snippet below:

/**
 * @dataProvider DataProvider
 * @test
 */
public function shouldThrowAnExceptionInWebhookTryFailure(object $webhook, array $payload)
{
    $webhookCallJob = WebhookCall::create()
        ->url($webhook->url)
        ->payload($payload)
        ->maximumTries(1)
        ->throwExceptionOnFailure(true)
        ->useSecret(Str::uuid());

    $this->expectException(Throwable::class);

    $webhookCallJob->dispatch();
}