Empty string check when setting a property. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added empty string check when setting a property.
Gummibeer
requested changes
Oct 17, 2020
Update generator\templates\static\BaseType.php Moved the piece of code that checks for empty strings #151 to Generator Template file.
|
Thanks and sorry about that. I should have be more familiar with the project before submiting any request. Also, I'm still learning how Github works 😅. |
Gummibeer
approved these changes
Oct 17, 2020
|
Everything fine! 😉 That's why we review PRs before merging. 😊 Thanks for the quick fix. I'm on the road right now - but seems good. |
Gummibeer
approved these changes
Oct 22, 2020
Gummibeer
added
enhancement
Hacktoberfest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update BaseType.php
Added empty string check when setting a property.
Fixes issue #151