Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change cardinality of specVersion to required #421

Closed
goneall opened this issue Jul 13, 2023 · 4 comments · Fixed by #422
Closed

Proposal: Change cardinality of specVersion to required #421

goneall opened this issue Jul 13, 2023 · 4 comments · Fixed by #422
Labels
Profile:Core Core Profile and related matters
Milestone

Comments

@goneall
Copy link
Member

goneall commented Jul 13, 2023

Not having the specVersion in the creation info will make certain validation, conversion and parsing unreliable.

Note that this is already required in SPDX 2.3 and all previous versions.

@goneall goneall added the Profile:Core Core Profile and related matters label Jul 13, 2023
@goneall goneall added this to the 3.0-rc2 milestone Jul 13, 2023
@davaya
Copy link
Contributor

davaya commented Jul 14, 2023

Yes.

@armintaenzertng
Copy link
Contributor

I absolutely agree, no version info will totally trip up tooling.

I opened #422 to fix this.

@armintaenzertng
Copy link
Contributor

While we are at it, should dataLicense be mandatory, too? (If this requires more discussion, we can open a separate issue.)

@goneall
Copy link
Member Author

goneall commented Jul 14, 2023

While we are at it, should dataLicense be mandatory, too? (If this requires more discussion, we can open a separate issue.)

There is a change proposal to make the dataLicense optional - so we should wait until that is resolved before changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:Core Core Profile and related matters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants