Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can hasHost Relationship link to Build #915

Open
ilans opened this issue Nov 14, 2024 · 5 comments
Open

Can hasHost Relationship link to Build #915

ilans opened this issue Nov 14, 2024 · 5 comments
Labels
Profile:Build Build Profile and related matters Profile:Core Core Profile and related matters
Milestone

Comments

@ilans
Copy link
Collaborator

ilans commented Nov 14, 2024

In RelationshipType:

hasHost: The from Build was run on the to Element during a LifecycleScopeType period (e.g. the host that the build runs on).

In the Build profile:

hasHost: Describes the relationship from the Build element to the build stage or host.

Can a Relationship with hasHost really link to a Build?
Seems wrong.

@ilans ilans added the Profile:Build Build Profile and related matters label Nov 14, 2024
@zvr zvr added this to the 3.0.1 milestone Nov 14, 2024
@goneall
Copy link
Member

goneall commented Nov 14, 2024

From what I understand, the intent was to link to a build.

@lumjjb @nishakm - Thoughts?

@goneall
Copy link
Member

goneall commented Nov 14, 2024

Discussed with Kate and we're thinking this should be 3.1 - we don't have any validation in place other than the text, so I don' think fixing it will be a breaking change.

@goneall goneall modified the milestones: 3.0.1, 3.1 Nov 14, 2024
@nishakm
Copy link
Collaborator

nishakm commented Nov 14, 2024

Host machines provide dependencies for build to function. Hence we added a "hasHost" relationship.

@nishakm
Copy link
Collaborator

nishakm commented Nov 14, 2024

@goneall bringing in host machines into the build story allows for the inclusion of build runners in the SBOM. Hence I would strongly recommend NOT removing this relationship.

@goneall
Copy link
Member

goneall commented Nov 14, 2024

@goneall bringing in host machines into the build story allows for the inclusion of build runners in the SBOM. Hence I would strongly recommend NOT removing this relationship.

Just to clarify, I don't think anyone is proposing we remove the relationship - just clarifying the to / from types.

We may need to clarify the language a bit - @ilans is working on translating the English text to SHACL restrictions, and we want to make sure we get the details right.

@bact bact added the Profile:Core Core Profile and related matters label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:Build Build Profile and related matters Profile:Core Core Profile and related matters
Projects
None yet
Development

No branches or pull requests

5 participants