Make FilesAnalyzed a pointer, assume "true" if absent #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
|
Hi @ianling -- there was a significant refactoring in this library, are you able to adjust this PR for the changes? Also, you will need to sign-off your commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
Depends on and contains commits from #134, #135, #137, #138, and #139
Per the spec, FilesAnalyzed is not required to be present. If it is not present, the value is assumed to be
true.This was previously handled using a secondary field that denoted whether or not FilesAnalyzed was present.
This PR removes that field and makes FilesAnalyzed a pointer to denote that it is not required to be present.
All of the parsers interpret an absence of a value as
true.All of the file writers will ALWAYS write a value for FilesAnalyzed, either true or false, they will never omit it. I think it is better for SPDX files to be explicit.