Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅-up linked tests #1374

Closed
3 tasks
marcoscaceres opened this issue Aug 28, 2017 · 24 comments
Closed
3 tasks

💅-up linked tests #1374

marcoscaceres opened this issue Aug 28, 2017 · 24 comments

Comments

@marcoscaceres
Copy link
Contributor

Given that tests names themselves contain details about what kinds of tests they are, we can use that information to make the tests a bit nicer.

  • requires secure connection 🔒
  • manual tests 💪
  • automated test 🤖

so, it would be like: manual test (💪), requires secure connection (🔒) test-name.

And we can drop the .html part.

@shikhar-scs
Copy link
Contributor

If this issue is still up @marcoscaceres may I work on it ?

@marcoscaceres
Copy link
Contributor Author

Sure is! Absolutely, you can take it. Take a look at: https://w3c.github.io/payment-request/

And search for “tests”. You will see what I mean there. There is lots we could do.

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 5, 2018

Do you mean this

hhiih

@marcoscaceres
Copy link
Contributor Author

Yep, exactly those.

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 5, 2018

So, I'll get working with that. Meanwhile could you tell me how to access the specific tags (requires secure connection lock, manual tests muscle, automated test robot) related to a test ?

@marcoscaceres
Copy link
Contributor Author

Please see the developer guide: https://github.com/w3c/respec/wiki/Developers-Guide

Will send details tomorrow as to where the actual code is. However, it be good to discuss a proposal and do some mock-ups before coding anything. This is mostly UI work, so want to make sure we see something nice/usable before we start coding.

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 5, 2018

This is mostly UI work, so want to make sure we see something nice/usable before we start coding.

Sure thing 👍

Will send details tomorrow as to where the actual code is.

I'll try and find them on my own else lookout for it tomorrow 😃

EDIT : would be better if you could help me with the details

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 6, 2018

@marcoscaceres If you could help here a bit 😄

Will send details tomorrow as to where the actual code is. However, it be good to discuss a proposal and do some mock-ups before coding anything. This is mostly UI work, so want to make sure we see something nice/usable before we start coding.

Shall I contact you on IRC?

@marcoscaceres
Copy link
Contributor Author

Yeah, ping me on IRC.

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 6, 2018

Sure 👍 . Meanwhile I was waiting for this ->

Will send details tomorrow as to where the actual code is.

@marcoscaceres
Copy link
Contributor Author

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 6, 2018

Thanks for all this , I'll follow it up soon. 😄

@marcoscaceres
Copy link
Contributor Author

ok, but please run your ideas by me as you go. We are going to try to align with BikeShed, as they are doing something very similar: speced/bikeshed#1116

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 6, 2018

Sure! Btw, your name has been missing on IRC at #spec channel

it is #specs. Sorry ! found it

@marcoscaceres
Copy link
Contributor Author

Sorry, went to the gym 💪 My timezone is GMT+10 (Melbourne, Australia).

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 6, 2018

@marcoscaceres No problem at all. I very easily understand the code now.

However, I have a doubt. Whenever I make changes to the href logic below, it does not reflect in the test dropdown present in the basic.html file
https://github.com/w3c/respec/blob/34822ee20dcbbf186e81d9bfbccd66dc3d51913e/src/core/data-tests.js#L25-L31

we can do away with the .html part here itself. Also, where can I access the tags related to a test ?

@marcoscaceres
Copy link
Contributor Author

Ah, about it not reflecting, did you do?:

npm run babel:watch

That will compile the code for you. I'm around for the next 6 hours or so on IRC. Ping me on there and we can get you up and running.

@shikhar-scs
Copy link
Contributor

Oops! completely forgot about that. Thanks for reminding.
I have college a bit earlier today, so I wont be around that much for a couple of hours. I'll catch up in a while. Thankyou for your help 🙇‍♂️

@shikhar-scs
Copy link
Contributor

@marcoscaceres Can you please tell me again where can I get the tags related to a test ?

@marcoscaceres
Copy link
Contributor Author

@shikhar-scs, I'm not exactly sure what you mean by tags? Can you clarify?

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Feb 7, 2018

so, it would be like: manual test (muscle), requires secure connection (lock) test-name.

These i.e. manual, requires secure connection etc

@shikhar-scs
Copy link
Contributor

@marcoscaceres As of now, we have this (I have zoomed in for a better view)

heheheheehehe

To prettify it further, we should also remove the dashes I guess. Please review

@marcoscaceres
Copy link
Contributor Author

Looking good, @shikhar-scs.

@shikhar-scs
Copy link
Contributor

Should I file a PR for the same ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants