Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ValueFormatter and LabelColor to BarChart #1382

Open
jsheely opened this issue Nov 26, 2023 · 1 comment
Open

Adding ValueFormatter and LabelColor to BarChart #1382

jsheely opened this issue Nov 26, 2023 · 1 comment

Comments

@jsheely
Copy link
Contributor

jsheely commented Nov 26, 2023

Is your feature request related to a problem? Please describe.
The BreakdownChart has the ability to do ValueFormatter but Barchart does not.

Describe the solution you'd like
I 've added the ValueFormatter to the Barchart so that you can format numbers like 1234 -> 1,234

Additional context
I've also the ability to color the label of the Barchart label using a property

I have a PR ready for this but opening an issue as per request.


Please upvote 👍 this issue if you are interested in it.

@jsheely
Copy link
Contributor Author

jsheely commented Nov 28, 2023

I can split these into two separate issues if needed but for my project needs I wanted them both.

  • The ValueFormatter seems inline with how the other class works and seems straight forward.
  • The colorization using a property instead of relying on the [green] notation is a little more subjective.

Let me know your thoughts and I will adjust accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo 🕑
Development

No branches or pull requests

1 participant