fix: omit sink state from hash to avoid double-emitting on VR creation

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
validator-labs · Nov 9, 2023 · 071b960 · 071b960
1 parent 4903786
commit 071b960
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/api/v1alpha1/validationresult_test.go b/api/v1alpha1/validationresult_test.go
@@ -39,7 +39,7 @@ func TestHash(t *testing.T) {
 					},
 				},
 			},
-			expectedHash: "mCyJwAeP5yOG82mDw8Yy1Q==",
+			expectedHash: "Ldcfr8OZ6D/LRuLfasCrKg==",
 		},
 	}
 	for _, c := range cs {

diff --git a/api/v1alpha1/validationresult_types.go b/api/v1alpha1/validationresult_types.go
@@ -104,7 +104,6 @@ func (r *ValidationResult) Hash() string {
 	fmt.Fprint(digester, r.ObjectMeta.UID)
 	fmt.Fprint(digester, r.Spec)
 	fmt.Fprint(digester, r.Status.State)
-	fmt.Fprint(digester, r.Status.SinkState)
 
 	if len(r.Status.Conditions) > 0 {
 		c := r.Status.Conditions[0].DeepCopy()