Skip to content

Commit

Permalink
fix: use http to make request to gRPC server (#157)
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmad-ibra authored Dec 19, 2023
1 parent 2ae0348 commit 1c960f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/controller/validatorconfig_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ func (r *ValidatorConfigReconciler) emitFinalizeCleanup() error {
return fmt.Errorf("CLEANUP_GRPC_SERVER_PORT is invalid: %w", err)
}

url := fmt.Sprintf("https://%s:%s", host, port)
url := fmt.Sprintf("http://%s:%s", host, port)
client := cleanupv1connect.NewCleanupServiceClient(
http.DefaultClient,
url,
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/validatorconfig_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ func TestEmitFinalizeCleanup(t *testing.T) {
"CLEANUP_GRPC_SERVER_HOST": "localhost",
"CLEANUP_GRPC_SERVER_PORT": "1234",
},
expected: errors.New(`FinalizeCleanup request to https://localhost:1234 failed: unavailable: dial tcp [::1]:1234: connect: connection refused`),
expected: errors.New(`FinalizeCleanup request to http://localhost:1234 failed: unavailable: dial tcp [::1]:1234: connect: connection refused`),
},
}
for _, c := range cs {
Expand Down

0 comments on commit 1c960f8

Please sign in to comment.