Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alertmanager sink #107

Merged
merged 16 commits into from
Nov 15, 2023
Merged

feat: add alertmanager sink #107

merged 16 commits into from
Nov 15, 2023

Conversation

TylerGillson
Copy link
Member

No description provided.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #107 (e3e7788) into main (36ce4a1) will increase coverage by 2.26%.
The diff coverage is 79.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   41.93%   44.19%   +2.26%     
==========================================
  Files           6        9       +3     
  Lines         589      810     +221     
==========================================
+ Hits          247      358     +111     
- Misses        322      428     +106     
- Partials       20       24       +4     
Files Coverage Δ
api/v1alpha1/validatorconfig_types.go 100.00% <ø> (ø)
internal/sinks/sink.go 100.00% <100.00%> (ø)
internal/sinks/slack.go 0.00% <0.00%> (ø)
internal/controller/validationresult_controller.go 63.82% <0.00%> (ø)
internal/sinks/alertmanager.go 80.90% <80.90%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ce4a1...e3e7788. Read the comment docs.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra previously approved these changes Nov 15, 2023
Copy link
Contributor

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit 855e70e into main Nov 15, 2023
7 checks passed
@TylerGillson TylerGillson deleted the feat-alertmgr-sink branch November 15, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants