Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: accept VR in HandleNewValidationResult for flexibility in plugins #113

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

TylerGillson
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #113 (ef349b6) into main (fc10444) will increase coverage by 5.11%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   44.69%   49.81%   +5.11%     
==========================================
  Files           9        9              
  Lines         801      791      -10     
==========================================
+ Hits          358      394      +36     
+ Misses        419      372      -47     
- Partials       24       25       +1     
Files Coverage Δ
pkg/validationresult/validation_result.go 79.31% <100.00%> (+49.41%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc10444...ef349b6. Read the comment docs.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit 1ead151 into main Nov 16, 2023
7 checks passed
@TylerGillson TylerGillson deleted the fix-vr-cleanup branch November 16, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant