Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: expose sink types #117

Merged
merged 1 commit into from
Nov 16, 2023
Merged

refactor: expose sink types #117

merged 1 commit into from
Nov 16, 2023

Conversation

TylerGillson
Copy link
Member

No description provided.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #117 (e0d4671) into main (9fbfff0) will increase coverage by 0.49%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   52.97%   53.47%   +0.49%     
==========================================
  Files           9        9              
  Lines         806      806              
==========================================
+ Hits          427      431       +4     
+ Misses        354      351       -3     
+ Partials       25       24       -1     
Files Coverage Δ
internal/controller/validationresult_controller.go 73.33% <100.00%> (+4.44%) ⬆️
internal/sinks/sink.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbfff0...e0d4671. Read the comment docs.

@TylerGillson TylerGillson merged commit f28d8af into main Nov 16, 2023
7 checks passed
@TylerGillson TylerGillson deleted the expose-sink-constants branch November 16, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant