Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support private helm repos #132

Merged
merged 14 commits into from
Nov 22, 2023
Merged

feat: support private helm repos #132

merged 14 commits into from
Nov 22, 2023

Conversation

TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Nov 22, 2023 •
edited
Loading

  • Add support for installing plugin charts within Helm repos using basic auth
  • Fix previously unhandled race conditions when updating the ValidatorConfig object and its status subresource

@TylerGillson
feat: support private helm repos
ba90304 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: retry VC status update & properly set failed conditions
2527569 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Merging #132 (81b4072) into main (9230953) will increase coverage by 2.57%.
The diff coverage is 83.33%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   52.60%   55.17%   +2.57%     
==========================================
  Files           9        9              
  Lines         806      850      +44     
==========================================
+ Hits          424      469      +45     
+ Misses        356      354       -2     
- Partials       26       27       +1
Files Coverage Δ
api/v1alpha1/validatorconfig_types.go 100.00% <ø> (ø)
internal/controller/validationresult_controller.go 73.62% <66.66%> (+0.29%) ⬆️
internal/controller/validatorconfig_controller.go 74.88% <83.87%> (+6.70%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9230953...81b4072. Read the comment docs.

@TylerGillson
fix: make authSecretName optional
dfe6058 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: make insecureSkipVerify optional
2372a74 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: sanitize Helm logs
bdfd104 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: prevent object modified errors on VC update
f9476f1 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra previously approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple questions but LGTM

@TylerGillson
refactor: fix logging/error handling for VC updates
9d35238 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
refactor: tidy ensureFinalizer signature
81b4072 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit cb0cf32 into main Nov 22, 2023
7 checks passed
@TylerGillson TylerGillson deleted the feat-private-helm branch November 22, 2023 23:20
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
@TylerGillson TylerGillson mentioned this pull request Feb 12, 2024
Closed
This was referenced Mar 8, 2024
Closed
Merged
@TylerGillson TylerGillson mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmad-ibra ahmad-ibra ahmad-ibra approved these changes

@mattwelke mattwelke Awaiting requested review from mattwelke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerGillson @ahmad-ibra