Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OCI plugin #139

Merged
merged 2 commits into from
Nov 30, 2023
Merged

feat: add OCI plugin #139

merged 2 commits into from
Nov 30, 2023

Conversation

ahmad-ibra
Copy link
Contributor

@ahmad-ibra ahmad-ibra commented Nov 29, 2023 •
edited
Loading

This PR adds the OCI validator plugin to the validator

The following cases were also manually tested and confirmed to be working as expected:

  • Creating credentials for multiple oci registries
  • Loading a custom proxy certificate

@ahmad-ibra ahmad-ibra marked this pull request as draft November 29, 2023 18:58
@ahmad-ibra ahmad-ibra force-pushed the feat-oci-plugin branch 3 times, most recently from 5a4184e to f34b57e Compare November 29, 2023 19:03
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #139 (bace433) into main (90c6f41) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files           9        9           
  Lines         850      850           
=======================================
  Hits          469      469           
  Misses        354      354           
  Partials       27       27

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c6f41...bace433. Read the comment docs.

@ahmad-ibra ahmad-ibra force-pushed the feat-oci-plugin branch 4 times, most recently from 108ffa7 to c5a5623 Compare November 30, 2023 20:29
@ahmad-ibra ahmad-ibra marked this pull request as ready for review November 30, 2023 20:31
@ahmad-ibra ahmad-ibra marked this pull request as draft November 30, 2023 20:33
TylerGillson
TylerGillson previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TylerGillson TylerGillson marked this pull request as ready for review November 30, 2023 20:43
TylerGillson
TylerGillson previously approved these changes Nov 30, 2023
View reviewed changes
TylerGillson
TylerGillson approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahmad-ibra ahmad-ibra merged commit 3ae7b70 into main Nov 30, 2023
7 checks passed
@ahmad-ibra ahmad-ibra deleted the feat-oci-plugin branch November 30, 2023 21:26
@github-actions github-actions bot mentioned this pull request Nov 30, 2023
Merged
@TylerGillson TylerGillson mentioned this pull request Feb 12, 2024
Closed
This was referenced Mar 8, 2024
Closed
Merged
@TylerGillson TylerGillson mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerGillson TylerGillson TylerGillson approved these changes

@mattwelke mattwelke Awaiting requested review from mattwelke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmad-ibra @TylerGillson