fix: dynamically set cleanup wait time #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of testing i noticed that at the high end, it takes a little under 10 seconds to delete each plugin thats added. This is mostly due to the synchronous portion of the deletePlugin function. To combat this, we can dynamically set the wait time to
10 * len(plugins)
. This will ensure we wont have long wait times when a user only adds a couple plugins.