Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamically set cleanup wait time #143

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

ahmad-ibra
Copy link
Contributor

After a lot of testing i noticed that at the high end, it takes a little under 10 seconds to delete each plugin thats added. This is mostly due to the synchronous portion of the deletePlugin function. To combat this, we can dynamically set the wait time to 10 * len(plugins). This will ensure we wont have long wait times when a user only adds a couple plugins.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #143 (2cf2e1e) into main (a3fc0dc) will decrease coverage by 0.82%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   55.84%   55.02%   -0.82%     
==========================================
  Files           9        9              
  Lines         856      856              
==========================================
- Hits          478      471       -7     
- Misses        353      357       +4     
- Partials       25       28       +3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fc0dc...2cf2e1e. Read the comment docs.

Copy link
Member

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TylerGillson TylerGillson self-requested a review December 1, 2023 20:59
@ahmad-ibra ahmad-ibra merged commit 13d0399 into main Dec 1, 2023
6 of 7 checks passed
@ahmad-ibra ahmad-ibra deleted the dynamic-cleanup-wait branch December 1, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants