Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use http to make request to gRPC server #157

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

ahmad-ibra
Copy link
Contributor

Addresses this error encountered during tests:

ERROR    controllers.ValidatorConfig    Failed to emit FinalizeCleanup request    {"error": "FinalizeCleanup request to https://validator-cleanup-service:3006 failed: unavailable: http: server gave HTTP response to HTTPS client"}

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #157 (0107bc4) into main (2ae0348) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   56.69%   57.03%   +0.33%     
==========================================
  Files           9        9              
  Lines         889      889              
==========================================
+ Hits          504      507       +3     
+ Misses        357      356       -1     
+ Partials       28       26       -2     
Files Coverage Δ
internal/controller/validatorconfig_controller.go 78.29% <100.00%> (+1.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae0348...0107bc4. Read the comment docs.

@ahmad-ibra ahmad-ibra marked this pull request as ready for review December 18, 2023 22:59
@ahmad-ibra ahmad-ibra requested review from a team and TylerGillson December 18, 2023 22:59
@ahmad-ibra ahmad-ibra merged commit 1c960f8 into main Dec 19, 2023
10 of 11 checks passed
@ahmad-ibra ahmad-ibra deleted the fix/grpc-req branch December 19, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants