Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SafeUpdateValidationResult: update VR spec and status #205

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

TylerGillson
Copy link
Member

No description provided.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team February 6, 2024 16:17
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #205 (de4de61) into main (dad6535) will decrease coverage by 0.24%.
The diff coverage is 83.33%.

❗ Current head de4de61 differs from pull request most recent head 0d0d5b0. Consider uploading reports for the commit 0d0d5b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   56.73%   56.49%   -0.24%     
==========================================
  Files           9        9              
  Lines         728      731       +3     
==========================================
  Hits          413      413              
- Misses        288      290       +2     
- Partials       27       28       +1     
Files Coverage Δ
pkg/validationresult/validation_result.go 96.34% <83.33%> (-3.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad6535...0d0d5b0. Read the comment docs.

@TylerGillson TylerGillson merged commit 972eb55 into main Feb 6, 2024
9 checks passed
@TylerGillson TylerGillson deleted the fix/vr-count-update branch February 6, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants