From bdbcb376d14608a834d363be6b24613eecd1a2f1 Mon Sep 17 00:00:00 2001 From: Artur Shad Nik Date: Wed, 13 Nov 2024 18:26:51 -0800 Subject: [PATCH 1/3] docs: add note about vddk secret namespace Signed-off-by: Artur Shad Nik --- .../create-manage-vm/advanced-topics/migrate-vm-kubevirt.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md b/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md index ef464bc582..b785de55d9 100644 --- a/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md +++ b/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md @@ -88,7 +88,8 @@ from VMware vSphere to Palette VMO. documentation for guidance. - The migration host must have access to your image registry. - If you are using a private image registry, you must create a Secret to be used for the migration. The Secret must be - in the form of a YAML file and the `metadata.name` value must be `vddk-image-pull-secret`. + in the form of a YAML file and the `metadata.name` value must be `vddk-image-pull-secret`. The `metadata.namespace` value + should be left blank, it will be automatically populated by Palette CLI.
@@ -130,7 +131,7 @@ from VMware vSphere to Palette VMO. ``` You can then use this output to create your own Secret manually. Ensure that the `metadata.name` is set to - `vddk-image-pull-secret`. + `vddk-image-pull-secret` and the `metadata.namespace` is left blank. Refer to the [Pull an Image from a Private Registry documentation](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/) From b68e86fb40af616703aec3d9bc1190f369768537 Mon Sep 17 00:00:00 2001 From: arturshadnik Date: Thu, 14 Nov 2024 02:47:49 +0000 Subject: [PATCH 2/3] ci: auto-formatting prettier issues --- .../create-manage-vm/advanced-topics/migrate-vm-kubevirt.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md b/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md index b785de55d9..e7e63fe10d 100644 --- a/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md +++ b/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md @@ -88,8 +88,8 @@ from VMware vSphere to Palette VMO. documentation for guidance. - The migration host must have access to your image registry. - If you are using a private image registry, you must create a Secret to be used for the migration. The Secret must be - in the form of a YAML file and the `metadata.name` value must be `vddk-image-pull-secret`. The `metadata.namespace` value - should be left blank, it will be automatically populated by Palette CLI. + in the form of a YAML file and the `metadata.name` value must be `vddk-image-pull-secret`. The `metadata.namespace` + value should be left blank, it will be automatically populated by Palette CLI.
From e241687a9c311e1bf86b49c6e5e172d8adafb1ee Mon Sep 17 00:00:00 2001 From: Ben Radstone <56587332+benradstone@users.noreply.github.com> Date: Thu, 14 Nov 2024 10:27:16 +0000 Subject: [PATCH 3/3] docs: code review --- .../create-manage-vm/advanced-topics/migrate-vm-kubevirt.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md b/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md index e7e63fe10d..9d21a5e8a5 100644 --- a/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md +++ b/docs/docs-content/vm-management/create-manage-vm/advanced-topics/migrate-vm-kubevirt.md @@ -89,7 +89,7 @@ from VMware vSphere to Palette VMO. - The migration host must have access to your image registry. - If you are using a private image registry, you must create a Secret to be used for the migration. The Secret must be in the form of a YAML file and the `metadata.name` value must be `vddk-image-pull-secret`. The `metadata.namespace` - value should be left blank, it will be automatically populated by Palette CLI. + value should be left blank or omitted, as the Palette CLI will automatically populate it.
@@ -131,7 +131,7 @@ from VMware vSphere to Palette VMO. ``` You can then use this output to create your own Secret manually. Ensure that the `metadata.name` is set to - `vddk-image-pull-secret` and the `metadata.namespace` is left blank. + `vddk-image-pull-secret`, and the `metadata.namespace` is left blank or omitted. Refer to the [Pull an Image from a Private Registry documentation](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/)