Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme to mention workaround needed for CRA and wasm. #1

Open
campbellbartlett opened this issue Sep 3, 2021 · 2 comments
Open

Comments

@campbellbartlett
Copy link

I initially gave his a try by throwing together a quick create-react-app and adding the ergo-sdk-js dependency, without realising there is a workaround required for using web assembly with create-react-app.

It took me a while to work out why, I found the answer by looking at the readme of the ergo-lib-wasm-browser readme.

It would be good to add the same comment about the required workaround to this repositories readme. What do you think?

@oskin1
Copy link
Member

oskin1 commented Sep 4, 2021

I initially gave his a try by throwing together a quick create-react-app and adding the ergo-sdk-js dependency, without realising there is a workaround required for using web assembly with create-react-app.

It took me a while to work out why, I found the answer by looking at the readme of the ergo-lib-wasm-browser readme.

It would be good to add the same comment about the required workaround to this repositories readme. What do you think?

@campbellbartlett do you mean this? https://github.com/ergoplatform/sigma-rust/tree/develop/bindings/ergo-lib-wasm#when-i-build-the-ergo-lib-wasm-and-include-the-pkg-folder-as-dependency-in-my-app-i-get-typeerror-textdecoder-is-not-a-constructor

@campbellbartlett
Copy link
Author

Yeah sort of, actually this one: https://github.com/ergoplatform/sigma-rust/tree/develop/bindings/ergo-lib-wasm#using-with-create-react-app

Is it worth adding a similar note in the readme of this repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants