Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small changes #5

Merged
merged 1 commit into from
Dec 1, 2023
Merged

small changes #5

merged 1 commit into from
Dec 1, 2023

Conversation

crenshaw-dev
Copy link
Collaborator

@speedfl I made some small changes.

  • Move applyTemplatePatch into the controllers package to avoid exposing a public function.
  • Enforce not allowing the template patch to modify the project field - avoids malicious param values causing problems.
  • Refactored the tests a bit and added a test case for the project change.

@crenshaw-dev
small changes
27f5d1d 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@speedfl speedfl merged commit 47f5743 into speedfl:feature/advanced-templating Dec 1, 2023
1 of 2 checks passed
@speedfl
Copy link
Owner

speedfl commented Dec 1, 2023

Thanks for the updates @crenshaw-dev

@crenshaw-dev crenshaw-dev deleted the template-patch-changes branch December 1, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crenshaw-dev @speedfl