Xsd format fixes misc features #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes not in the xsd
|
@codito Hey, if you are around and want to take a look that would be great. Otherwise I will merge and try to get the issue creators to review a pre-release version. Either way, getting the xsd validation should be a clear improvement. I will also do some testing against at least the gitlab parser before I merge. |
codito
reviewed
Feb 12, 2020
| @@ -282,9 +312,18 @@ internal void TestRunCompleteHandler(object sender, TestRunCompleteEventArgs e) | |||
| Directory.CreateDirectory(loggerFileDirPath); | |||
| } | |||
|
|
|||
| var settings = new XmlWriterSettings() | |||
| { | |||
| Encoding = new UTF8Encoding(this.FileEncodingOption == FileEncoding.UTF8 ? false : true), | |||
There was a problem hiding this comment.
this.FileEncodingOption == FileEncoding.UTF8 should work.
test/JUnit.Xml.TestLogger.AcceptanceTests/JUnitTestLoggerAcceptanceTests.cs
Outdated
Show resolved
Hide resolved
test/JUnit.Xml.TestLogger.AcceptanceTests/JUnitTestLoggerAcceptanceTests.cs
Show resolved
Hide resolved
codito
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12, #16, #17, #18.