-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Historical timezone data #88
Comments
yes, that's correct. I think there are some no-longer-used timezones in our list, but yes, we only record their latest offset+dst change. |
Don't you want to change add this capability (as optional)? This would make spacetime more universal, allowing to use it in projects that work with historical dates. |
yeah, it gets pretty complex, the further-back you go. |
To further @spencermountain’s point, the entire reason we created Spacetime at @smallwins was because date/time libraries with full historical databases were too large and slow and clunky. So this suggestion kind of negates the whole point of the thing. Perhaps check out Moment, @whitecolor? |
Well, probably there could be created a separate package that would hold the database and use @ryanblock I use moment-timezone, it requires I just thought that |
been thinking about this a little, and it'd be fun to implement in a separate package somehow. if you run this, you'll see most computers (mine, atleast) have dst-change info back as far as 1900: zdump -v /usr/share/zoneinfo/canada/pacific it'd be fun to turn this into a cleaner json diff, and see how small we can make it. I guess the names/ids of tzs change too, so stalingrad time in 1992 would have some weird edges, and things like this. if anyone wants to work on it with me, holler. |
What do you mean by no-longer-used timezones? All deprecated on the IANA list? I've got an error Love your work, greetz! |
@Fellach good question. I think we should include deprecated IANA zones. We have most of them now, i believe. Happy to add I'm working on softening things up in a seperate lib for reconciling timezones, like |
Yeah, I've also been getting invalid IANA timezone for 'cet'. Strange enough, when I wrote a unit test to cover this, it doesn't complain. I've also tried putting it through informal.find and still I get this error sometimes. |
agh weird. Yeah, spacetime-informal should be able to convert |
So if I see it right this library doesn't use tz database full data that is used by https://momentjs.com/timezone/ and thus can not be used for historical dates, is spacetime intended only for current moment dates conversions?
The text was updated successfully, but these errors were encountered: