-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review inconsistent go
file license headers
#1699
Comments
This isn't quite right. I can't hold a copyright on other peoples contributions without a copyright assignment agreement (which we don't have in place and I don't want to do this anyway). I added that header when all the contributions were mine (a very long time ago). The better approach is to make all of the headers consistent as follows.
The Cobra Authors can be obtained by running Speaking of Authors files, we should probably add one. See https://github.com/golang/go/blob/master/AUTHORS for an example of this. This is the only approach I've seen work. Otherwise files become very messy with everyone trying to add their own copyright to each file. |
Steve's approach sounds right to me. By the way, the CNCF doesn't seem to ask for an "authors" file and Helm doesn't use one. So we may prefer to avoid having one just to avoid having to keep it up to date. But if @spf13 prefers to have one, that's fine with me. |
The Cobra project currently lacks enough contributors to adequately respond to all issues. This bot triages issues and PRs according to the following rules:
|
FTR: golang/go@774fa58
|
Problem
Today, we have wildy inconsistent license headers in our
go
source files.go
files do not have a license header.Expectation
From my understanding of the Apache 2.0 license, source files should have the license header, otherwise, it seems that only some of the source code is under the Apache 2.0 license and the others are ... unlicensed?
We should be consistent.
Further, we should set up a CICD job to fail if someone commits something without the license header.
@spf13 - can you advice here? Should the expectation be that we have:
in all go source files?
The text was updated successfully, but these errors were encountered: