Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with dep due to outdated semver tag #693

Closed
marksost opened this issue May 15, 2018 · 2 comments
Closed

Issues with dep due to outdated semver tag #693

marksost opened this issue May 15, 2018 · 2 comments

Comments

@marksost
Copy link

Hey there! First - thanks so much for Cobra, it's great!

I ran into a small issue with using Cobra and dep recently, centered around the current 0.0.2 tag and it's being out of date with the latest in master.

When running dep init on a repo that uses Cobra, the following constraint gets added to the Gopkg.toml file:

[[constraint]]
  name = "github.com/spf13/cobra"
  version = "0.0.2"

That tag points to this commit a1f051b, however I'm using the FParseErrWhitelist property of the cobra.Command struct, which wasn't added until #662

I've gotten around this in dep by updating the constraint to point at the latest revision like so (I could also point it at the master branch, assumedly):

[[constraint]]
  name = "github.com/spf13/cobra"
  revision = "615425954c3b0d9485a7027d4d451fdcdfdee84e"

but was wondering if we could get a 0.0.3 tag added that includes all of the latest commits?

@eparis
Copy link
Collaborator

eparis commented May 15, 2018

why not.

@eparis eparis closed this as completed May 15, 2018
@marksost
Copy link
Author

Thanks @eparis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants