-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated files are not goimports
-ed
#933
Comments
I think this could be solved by fixing the template (https://github.com/spf13/cobra/blob/master/cobra/tpl/main.go), instead of requiring some specific lint/format tool. It seems that BTW, this is fixed in #876. |
Sure. I just added it as a reference. Go ahead, reopen #935 and ping @jharshman. This minor change is likely to be merged easily on it's own. |
Should this be closed now that #980 is merged? |
See https://travis-ci.org/andig/ingress/builds/575241832#L232 for an example. It seems as if cobra templates prefer spaces for indent while goimport wants tabs.
Would it make sense to enhance the cobra utility command to goimport or gofmt the generated assets?
The text was updated successfully, but these errors were encountered: