Add ability to canonify URLs in rendered XML output. #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any reason not to canonify urls in XML feeds? Seems like it should happen regardless of the |
|
I see no good reason why it shouldn't always be canonified. Maybe @spf13 have some input? |
|
I can't see a good reason for it not to be always canonified either. I think this is simply an oversight from that canonization feature, a recent addition. |
popthestack
force-pushed
the
fix/canonify-urls-in-xml
branch
from
4b49d0b
to
54fd48b
Compare
|
Modified it so the rendered XML always canonifies urls. The failed test is unrelated ( |
|
Merged in 7dacc99. Good catch. |
This was referenced Jan 17, 2015
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #725.
I'm not sure if I'm approaching this the right way. Please let me know what needs improvement.
Notes:
AbsURLInXMLassumes content will be escaped with| html.AbsURLInXMLshould also look for unescaped content.