-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS feeds do not validate #789
Comments
Thank you for reporting this issue, @snej. For those who are interested, here is what I have learned thus far. According to the RSS 2.0 Specification:
I have modified the rss.xml template in However, the other errors aren't as trivial:
It would seems that to get feeds of pages with extras like I am too new to Go and to the Hugo team to tackle that. Should something like this (probably an enhancement rather than a bugfix) be added to Hugo? Please discuss. :-) |
The UTF-8 vs ASCII issue is a well-known thorny one. It's an HTTP-level problem, so it's really outside the purview of a static site generator. The deploying site has to do something to set the correct Content-Type header when serving the file. It can be done with a The limits on the |
FYI, the feed generated for my website by Hugo v0.12 has different validation errors that aren't listed above:
|
Yes, indeed, though there is currently no mechanism to fix bugs for old stable release, i.e. no v0.12.1 would be made to fix bugs, so we will have to look forward to v0.13, which will hopefully be released soon. |
It turns out other users have reported this specific problem in #725 and #728 too! And already fixed by the reporter @popthestack in commit 7dacc99 22 days ago! (Thank you @popthestack!) So one more step towards perfect RSS feed output! :-) |
😀 👍 |
There is some work involved getting these all valid. On my site, it complains about script and iframe tags ... |
@bjornerik: As I mentioned above, the complaints about the [escaped] tags used in the HTML descriptions are pretty minor. Technically a feed's descriptions shouldn't contain "unsafe" HTML, but in the real world it happens and the feed readers can protect themselves against it in one way or another. |
@snej: Thanks for the note! Though there is always room for improvement in our strive for perfection, so I think it is likely that we will keep this issue open, but leaving it as a milestone for some future release beyond v0.13, say, v0.50? :-) |
Unsure what remains to be done with RSS validation, most of the validation errors seem to have been fixed with various commits referenced in this issue. Among my 4 primary feeds at techglider.in, I see a warning with just one as follows, but all 4 do validate on feedvalidator.org:
As @snej mentions, these warnings should be ignorable from the perspective of hugo development. |
I also had to replace the |
@bst27 what do you mean by having to replace URL with Url? Url is depracated in 0.14, but shouldn't be relevant for 0.13... Unless you use 0.14 docs in 0.13? |
I copied the given code from the docs and saved it in an rss.xml file (to customize it in a theme). Hugo gives me:
After removing
After changing |
Woopps. Then some Hugo 0.14 syntax has slipped into the 0.13 docs, sorry for that. |
Is this still the case? |
What is the status on this? |
I do not use Hugo at the moment so I cannot give you some feedback. |
RSS 2.0 requires the email be listed in `<author>`, and `UTC` as a timezone is not accepted, but `UT` or `GMT` are. See gohugoio#789 for more information. Thanks to @snej for the report!
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The RSS 2.0 feeds generated by Hugo do not validate. For example, look at feedvalidator.org's report on the spf13.com blog.
I spent several years working on a feed reader at Apple, and malformed feeds were the bane of my existence. It's not hard to check that you're generating a valid feed; please do so, for the sake of the feed readers!
The text was updated successfully, but these errors were encountered: