-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Roadmap to Sphinx-2.0 #4484
Comments
Cool! |
Surely 18.04? That will be released in a few months (2018-04).
I'd be a little nervous about this one. I agree that some builders could/should definitely be moved, but extensions are a whole other game. We should definitely discuss this at length. It will be controversial, but I think the biggest thing we could and should split out is The rest of this looks a-OK to me 👍 I would also like to slot in the work on a unified |
Thank you for comment!
Basically, we use active Ubuntu LTS to determine what version of tooling we have to support (ex, TeXLive).
Okay, let's discuss it. This is only my proposal, so it is not determined yet.
Sounds good. +1!!
Sorry, I don't have plan for visiting for now. |
Hello, I'm back from breaking about several years. How do you think about perfect (not PARTIAL!) Japanese language support? That includes:
And yesterday, I found:
Would you mind include/resolve these features/issues into Sphinx? If not, Why not? |
@Suzumizaki Thank you for proposal. That sounds good. Please send us PRs for them. I'll review them step by step. Always welcome :-) |
Thanks @tk0miya, I have a question. How to send you "PRs" as you say? For example, do you mean the normal pull request is NOT enough? |
PR = pull request 🙂 |
Yes, I meant normal pull requests 😄 |
@stephenfin @tk0miya Hahaha... Thanks, and sorry. I understand. I also cannot start suddenly now, but I will try to. later! |
Yes, but we will not be starting 2.0 development for another few months. Why not wait until 18.04 is out instead of 16.04? |
What I called "standard version" is used to determine what version of tooling we should support. It also uses for testing. We've chosen oldest ubuntu LTS for it. At present, the standard version is 14.04. So moving to 18.04 means relatively new toolings are not supported. |
Oh, where is this actually used? I imagine we'll still be using Travis for our CI tests so there's not reason we have to drop py35. FWIW, I develop and test on Fedora (27 at the moment) which comes with multiple Python versions 😄 |
It is used both testing and decision of support tooling. I don't understand why do you want to move "standard version" to 18.04. Note: I don't know "standard version" is good wording. criteria? base version? support platform? Anyway, I wrote its purpose on last message. |
Oh, just so that we're using the latest and greatest LTS distro. It seemed silly to use an older version when a newer one exists. Perhaps I am missing something. It is not a big deal either. |
I've been thinking a little more on this, and I don't think we should release 2.0 until spring 2020. The reason for this is An alternative approach would be to retain Python 2.7 support until 3.0. However, that might not be something you want to do? |
If we'll use latest LTS for testing, how do you confirm Sphinx works fine with old version?
Yes, it's difficult question. But, TBH, I can't imagine who uses py27 and latest Sphinx. So I prefer to extend support term of Sphinx-1.8 for a while (if somebody really wants).
If my opinion; the extension of support term is rejected, I'd like to vote this. |
OK, that's a good point. If it's only for testing, then 16.04 works. I personally use Fedora so it's good to have a spread of base OSes. The main issue I do see with 16.04 is my comment in
Either of these would be suitable for me. I just want to make sure we don't leave Python 2.7 users in the lurch with broken and unsupported Sphinx. |
Please wait for two years. It is too aggressive to request upgrading to 18.04 for all developers. |
Is there any comment for supporting py27? |
From my perspective, I would like to support this until 2020. This would probably mean we should wait to drop it until 3.0? |
I would really like to drop it, like Django. (but please use the
I think it would be better to make Sphinx 2.0 require Python 3, but continue bugfixes for the last 1.x release until 2020 for Python 2. Again, Django is doing something very similar with their LTS plan. |
I'd like to drop them all as soon as possible. So I prefer to separate codebase between 1.x and 2.x series on v2.0.0 release. Note: EOL of py2 is Jan 1, 2020 (see https://www.python.org/dev/peps/pep-0373/#maintenance-releases). |
I have to mention what "if maintainer exists" means. Personally, the extension of support term is not important to me. The EOL of python2 was announced 10 years ago (https://www.python.org/dev/peps/pep-0373/ ). And there is still time about one year for release of Sphinx-2.0. I think it is enough time to migrate. But it does not means I opposite to support it. I can agree to continue our supports if anybody want to do that. In other words, does anyone want to become a maintainer of 1.8 branch? I think dropping py2 support does not harm anybody. Sphinx-1.8 will not vanish even if 2.0 released. And users can use it with pinning the version. |
I agree that Sphinx-2.x series only supports Python 3. |
I am wondering if there will be some Sphinx 1.9 still supporting Python 2.7. I am asking this thinking about some LaTeX aspects which will be released with 2.0, but not with 1.8.x because they are not 100% backwards compatible (for example #5992, which slightly modifies the behaviour of image inclusion). Depending on whether the LaTeX changes involve also some changes in writers/latex.py it may be easy or not to backport from 2.0 branch to some 1.9.x series. If it is easy to backport then it could benefit some users (I expect some latency in moving all projects to Python3). |
There are no plan to release 1.9 series. 1.8.x will be final version of 1.x series. |
@jfbu Even if we wanted to, we couldn't support a 1.9 now. 2.0 is going to be Python 3 only and releasing a 1.9 release would mean reverting all the "drop Python 3" patches we have, along with needing to verify the features since work with Python 2.7. That's a lot of work :) |
I just released 2.0.0b1. And 2.0.0 final will be within a month. |
Goal of 2.0
Schedule
This schedule is not fixed. We can be adjusted depending on the situation.
I propose you not to release Sphinx-1.9.
About 1.8
DeprecationWarning
for 2.0Note.
This does not mention what new feature is added. This doesn't mean not to add new feature. It only means we don't have scheduled feature any more. So please go ahead same as so far.
In addition, this is a proposal from me (not fixed!). So please let me know your idea and update this.
The text was updated successfully, but these errors were encountered: